ioeric abandoned this revision.
ioeric added a comment.
Abandon in favor of https://reviews.llvm.org/D24800
https://reviews.llvm.org/D24717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ioeric added a comment.
In https://reviews.llvm.org/D24717#546279, @djasper wrote:
> I actually think this is a good example. So lets assume we'd write a tool to
> fully quote binary expressions, e.g. that turns
>
> if (a * b + c * d == 10) ...
>
>
> into
>
> if (((a * b) + (c * d)) == 10
djasper added a comment.
I actually think this is a good example. So lets assume we'd write a tool to
fully quote binary expressions, e.g. that turns
if (a * b + c * d == 10) ...
into
if (((a * b) + (c * d)) == 10) ...
So, here, we would be inserting two "(" and two ")" at the same locati
ioeric added a comment.
In https://reviews.llvm.org/D24717#546096, @djasper wrote:
> Thinking about this some more, starting to merge deletions now, but only some
> of them is a bit suspect. I think we either want to allow even more or
> continue to be restrictive for now.
>
> I think fundament
djasper added a comment.
Thinking about this some more, starting to merge deletions now, but only some
of them is a bit suspect. I think we either want to allow even more or continue
to be restrictive for now.
I think fundamentally, there are two questions that we need to answer:
1. Is this so
