sdardis added a comment.
Checking the generated IR for the incorrect uses of v8f16 shows that clang is
silently generating bitcasts from <8 x i16> to <4 x float>. There are some
other cases where the type of the operands is incorrect w.r.t. the builtin used.
I'm not familiar with the type check
sdardis closed this revision.
sdardis added a comment.
As stated I'll do a follow-up patch to fix the test. Committed as r281975.
Thanks,
Simon
https://reviews.llvm.org/D24674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D24674#547589, @vkalintiris wrote:
> @sdardis: can you update the review request before committing this because I
> don't think that test/CodeGen/builtins
vkalintiris requested changes to this revision.
vkalintiris added a comment.
This revision now requires changes to proceed.
@sdardis: can you update the review request before committing this because I
don't think that test/CodeGen/builtins-mips-msa.c has ever been properly
reviewed before.
htt
mpf added inline comments.
Comment at: test/CodeGen/builtins-mips-msa.c:8
@@ -13,4 +7,3 @@
+
typedef __fp16 v8f16 __attribute__ ((vector_size(16)));
vkalintiris wrote:
> @mpf
>
> Would it be problematic to expose this typedef from msa.h?
Yes it would unfortuna
sdardis added a comment.
@mpf
I'll correct the incorrect uses in a followup patch.
Thanks,
Simon
https://reviews.llvm.org/D24674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vkalintiris accepted this revision.
vkalintiris added a subscriber: mpf.
vkalintiris added a comment.
This revision is now accepted and ready to land.
LGTM with one comment/question inline.
Comment at: test/CodeGen/builtins-mips-msa.c:8
@@ -13,4 +7,3 @@
+
typedef __fp16 v8f16 _
