[PATCH] D24573: [CUDA] Do a better job at detecting wrong-side calls.

2016-10-08 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283637: [CUDA] Do a better job at detecting wrong-side calls. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D24573?vs=71381&id=74030#toc Repository: rL LLVM https://reviews

Re: [PATCH] D24573: [CUDA] Do a better job at detecting wrong-side calls.

2016-09-28 Thread Justin Lebar via cfe-commits
jlebar added a comment. I'm sorry to put more stuff on your plate, Richard, but you already have context on this, so you may be the best person to review this. Unfortunately people keep hitting the bug fixed here (and being confused), so it's maybe not as much of an edge case as I thought. FW

[PATCH] D24573: [CUDA] Do a better job at detecting wrong-side calls.

2016-09-14 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. Move CheckCUDACall from ActOnCallExpr and BuildDeclRefExpr to DiagnoseUseOfDecl. This lets us catch some edge cases we were missing, specifically around class operators. This necessitates a