This revision was automatically updated to reflect the committed changes.
Closed by commit rL283120: [CUDA] Disallow overloading destructors. (authored
by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24571?vs=71379&id=73413#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24
jlebar added inline comments.
> rnk wrote in SemaOverload.cpp:1131
> I feel like we should exit early on destructors here, before we do any target
> checks. The assert also feels kind of trivial because we only come into this
> overload machinery if looking up New's DeclarationName found Old.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> SemaOverload.cpp:1131
>
>if (getLangOpts().CUDA && ConsiderCudaAttrs) {
> CUDAFunctionTarget NewTarget = IdentifyCUDATarget(New),
I feel like we should
jlebar created this revision.
jlebar added a reviewer: rsmith.
jlebar added subscribers: tra, cfe-commits.
We'd attempted to allow this, but turns out we were doing a very bad
job. :)
Making this work properly would be a giant change in clang. For
example, we'd need to make CXXRecordDecl::getDe
