[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-10-06 Thread Asiri Rathnayake via cfe-commits
rmaprath closed this revision. rmaprath added a comment. Committed as r283441. Thanks! https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-10-06 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 73759. rmaprath added a comment. Final patch to be committed, with all the remaining comments addressed. https://reviews.llvm.org/D24562 Files: test/std/re/re.alg/re.alg.search/grep.pass.cpp test/std/re/re.regex/re.regex.assign/assign.pass.cpp test/s

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-10-05 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D24562#562339, @rmaprath wrote: > First batch of XFAIL fixes. > > I've changed some XFAILs to UNSUPPORTED where the test is all about exception > handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to > conditionally excl

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-10-05 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 73661. rmaprath added a comment. First batch of XFAIL fixes. I've changed some XFAILs to UNSUPPORTED where the test is all about exception handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to conditionally exclude those parts that t

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-10-04 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Feel free to send them in 10-20 at a time. It'll be much faster to review that way. https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-10-04 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D24562#561442, @Eugene.Zelenko wrote: > Looks like patch was not committed. Need to replicate this to as many tests as possible (~150). I was hoping to do all that and upload another diff for a final review, couldn't get to it I'm afraid.

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-10-04 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-09-15 Thread Asiri Rathnayake via cfe-commits
rmaprath added inline comments. Comment at: test/std/re/re.alg/re.alg.search/grep.pass.cpp:25 @@ -25,2 +24,3 @@ +#ifndef TEST_HAS_NO_EXCEPTIONS extern "C" void LLVMFuzzerTestOneInput(const char *data) EricWF wrote: > I prefer putting the `#if` on the inside of

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This approach looks great. I don't think we need to split things up into separate files. This is exactly how `test_macros.h` should be used. Feel free to convert as many tests as possible. I'v

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-09-14 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D24562#542630, @mclow.lists wrote: > What an awful test. I wonder who wrote such a steaming pile. Probably me. I think I've thrown quite a lot of XFAILs like this in the past, just to get the no-exceptions build passing. Now I've got to c

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-09-14 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. What an awful test. I wonder who wrote such a steaming pile. Probably me. https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-09-14 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 71349. rmaprath added a comment. (Added more context) https://reviews.llvm.org/D24562 Files: test/std/re/re.alg/re.alg.search/grep.pass.cpp Index: test/std/re/re.alg/re.alg.search/grep.pass.cpp ===

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

2016-09-14 Thread Asiri Rathnayake via cfe-commits
rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. When we added support for the no-exceptions build of `libc++`, all the tests that used exceptions got a blanket XFAIL for the no-exceptions variety. Previously, we tried to fi