This revision was automatically updated to reflect the committed changes.
Closed by commit rL304451: [SemaCXX] Add diagnostics to
require_constant_initialization (authored by kfischer).
Changed prior to commit:
https://reviews.llvm.org/D24371?vs=100949&id=101066#toc
Repository:
rL LLVM
http
loladiro added a comment.
Sure, I'll commit it.
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Go for it
On May 31, 2017 20:07, "Eric Fiselier via Phabricator" <
revi...@reviews.llvm.org> wrote:
> EricWF added a comment.
>
> @loladiro The patch doesn't apply correctly to the test. Do you mind if I
> hijack this and fix it?
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D24371
>
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. @loladiro Would you like to commit this?
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
EricWF updated this revision to Diff 100949.
EricWF added a comment.
- Fix patch so it applies cleanly.
https://reviews.llvm.org/D24371
Files:
lib/Sema/SemaDecl.cpp
test/SemaCXX/attr-require-constant-initialization.cpp
Index: test/SemaCXX/attr-require-constant-initialization.cpp
==
EricWF added a comment.
@loladiro The patch doesn't apply correctly to the test. Do you mind if I
hijack this and fix it?
Repository:
rL LLVM
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
EricWF added a comment.
@rsmith gentle ping.
Repository:
rL LLVM
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@rsmith ping.
Repository:
rL LLVM
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@rsmith ping. Any more comments on this patch?
Repository:
rL LLVM
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
loladiro updated this revision to Diff 70915.
loladiro added a comment.
Address review comments:
- Disable C++11 test that lacks source locations
- Use CacheCulprit to give diagnostics for < C++11
Repository:
rL LLVM
https://reviews.llvm.org/D24371
Files:
lib/Sema/SemaDecl.cpp
test/Sema
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10535-10538
@@ -10534,1 +10534,6 @@
<< attr->getRange();
+APValue Value;
+SmallVector Notes;
+cast(var->ensureEvaluatedStmt()->Value)->EvaluateAsInitializer(
+ Value, getAST
loladiro added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10535-10538
@@ -10534,1 +10534,6 @@
<< attr->getRange();
+APValue Value;
+SmallVector Notes;
+cast(var->ensureEvaluatedStmt()->Value)->EvaluateAsInitializer(
+ Value, getA
rsmith added a comment.
There's no way for `-verify` to test for a diagnostic with an invalid location
at the moment. Maybe add a FIXME and disable that portion of the test for C++11?
Comment at: lib/Sema/SemaDecl.cpp:10535-10538
@@ -10534,1 +10534,6 @@
<< attr->getR
loladiro created this revision.
loladiro added reviewers: EricWF, aaron.ballman, rsmith.
loladiro added a subscriber: cfe-commits.
loladiro set the repository for this revision to rL LLVM.
This hooks up the detailed diagnostics why constant initialization was not
possible if require_constant_init
14 matches
Mail list logo
