This revision was automatically updated to reflect the committed changes.
Closed by commit rL281378: Add bunch of _Interlocked builtins (authored by
agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24153?vs=70572&id=71223#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24153
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm Sorry, I lost track of this.
https://reviews.llvm.org/D24153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
majnemer added a comment.
In https://reviews.llvm.org/D24153#535992, @rnk wrote:
> Looks good to me. David, do you remember any subtleties here? I seem to
> recall there were some bugs in our intrin.h implementations, or
> inconsistencies between us and MSVC.
I can't seem to recall anything m
agutowski marked an inline comment as done.
agutowski added a comment.
https://reviews.llvm.org/D24153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
agutowski updated this revision to Diff 70572.
agutowski added a comment.
Mark _InterlockedIncrement and _InterlockedDecrement as non-volatile
https://reviews.llvm.org/D24153
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsic
rnk added a comment.
Looks good to me. David, do you remember any subtleties here? I seem to recall
there were some bugs in our intrin.h implementations, or inconsistencies
between us and MSVC.
Comment at: test/CodeGen/ms-intrinsics.c:297
@@ +296,3 @@
+// CHECK: define{{.*}}i1
agutowski created this revision.
agutowski added reviewers: rnk, compnerd, thakis.
agutowski added a subscriber: cfe-commits.
https://reviews.llvm.org/D24153
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
Index: lib/Hea
