Re: [PATCH] D24097: Add testcases for PR30188

2016-09-01 Thread Sebastian Pop via cfe-commits
sebpop abandoned this revision. sebpop added a comment. Agreed, this is a test for llvm/opt. I will submit another patch. https://reviews.llvm.org/D24097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [PATCH] D24097: Add testcases for PR30188

2016-08-31 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith requested changes to this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision now requires changes to proceed. This belongs in LLVM's test suite, not Clang's. https://reviews.llvm.org/D24097 ___

Re: [PATCH] D24097: Add testcases for PR30188

2016-08-31 Thread David Li via cfe-commits
davidxl added inline comments. Comment at: clang/test/CodeGen/pr30188.c:3 @@ +2,3 @@ + +// Check that optimizers are able to optimize the number of loads in the loop. +// CHECK: load Can you just do ... | grep load | count 3 Comment at: clang/

[PATCH] D24097: Add testcases for PR30188

2016-08-31 Thread Sebastian Pop via cfe-commits
sebpop created this revision. sebpop added reviewers: jmolloy, danielcdh, davidxl, mkuper, dberlin. sebpop added subscribers: llvm-commits, cfe-commits. Add testcases to clang test/ to make sure that the combined middle-end optimizations do not regress on optimizing the number of loads in the loop