[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-11-13 Thread Logan Chien via cfe-commits
logan closed this revision. logan added a comment. Thanks. Committed as https://reviews.llvm.org/rL286759. https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-11-12 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Nope LGTM. https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-11-11 Thread Logan Chien via cfe-commits
logan added a comment. Hi @EricWF: Would you mind if I commit this patch as-is? I believe `OFF` will is the better default value for ARM as well. Thanks. Logan https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-11-01 Thread Logan Chien via cfe-commits
logan added a comment. Hi @EricWF: Thanks for your comment. However, I think `OFF` is a better default for ARM (just like other platforms.) I usually use `libc++abi` without `libunwind` since `libgcc` is quite stable and usually linked by default. Besides, it is much more tricky to get the

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-10-31 Thread Logan Chien via cfe-commits
logan added a comment. Hi @EricWF and @mclow.lists: Do you have any comments? https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-10-31 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: CMakeLists.txt:117 option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF) option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF) option(LIBCXXABI_USE_COMPILER_RT "Use compiler-rt instead of l

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-10-31 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Is `ON` the right default for ARM? If so please apply the inline comment to fix the default settings.. Otherwise this LGTM. Comment at: CMakeLists.txt:117 option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF) option(LIBCXXABI_

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-10-04 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. LGTM too. @EricWF or @mclow.lists need to approve. https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-10-03 Thread Logan Chien via cfe-commits
logan added a comment. Ping? Any other comments? https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-08-31 Thread Renato Golin via cfe-commits
rengolin added a comment. That match would only make sense if LLVM's unwinder was forced on ARM targets, and they're most certainly not. Expecting both unwindwers to behave identically makes no sense. This fix looks good to me, but I'll let Marshall or Eric have a look first. https://reviews.

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

2016-08-31 Thread Logan Chien via cfe-commits
logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This commit fixes libc++abi build when LLVM unwinder (libunwind_llvm) is not enabled. This commit fixes the problem by