Re: [PATCH] D23999: [libc++] Minimal std::tuple fix for PR29123

2016-08-29 Thread Richard Smith via cfe-commits
rsmith added a comment. Ouch. This testcase is horrible. Note that we find two different ways to convert `Optional>` to itself: the obvious way, and `Optional> -> dynamic -> std::tuple -> Optional>` (because `tuple`'s conversion happens inside its converting constructor, this sidesteps the "at

Re: [PATCH] D23999: [libc++] Minimal std::tuple fix for PR29123

2016-08-29 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 69591. EricWF added a comment. Add testcase to patch. https://reviews.llvm.org/D23999 Files: include/__tuple include/tuple test/std/utilities/tuple/tuple.tuple/tuple.cnstr/PR29123_implicit_constructor_sfinae.pass.cpp Index: test/std/utilities/tuple/