Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-18 Thread Dean Michael Berris via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281879: [XRay] ARM 32-bit no-Thumb support in Clang (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D23932?vs=71635&id=71765#toc Repository: rL LLVM https://reviews.llvm.org

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-16 Thread Serge Rogatch via cfe-commits
rSerge updated this revision to Diff 71635. rSerge added a comment. Fixed patch file format. https://reviews.llvm.org/D23932 Files: test/CodeGen/xray-attributes-supported-arm.cpp Index: test/CodeGen/xray-attributes-supported-arm.cpp ===

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-16 Thread Serge Rogatch via cfe-commits
rSerge updated this revision to Diff 71629. https://reviews.llvm.org/D23932 Files: test/CodeGen/xray-attributes-supported-arm.cpp Index: test/CodeGen/xray-attributes-supported-arm.cpp === --- test/CodeGen/xray-attributes-supported

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-08 Thread Dean Michael Berris via cfe-commits
dberris requested changes to this revision. dberris added a comment. This revision now requires changes to proceed. See comments in https://reviews.llvm.org/D23931 for more details. https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-08 Thread Dean Michael Berris via cfe-commits
dberris reopened this revision. dberris added a comment. This revision is now accepted and ready to land. Reverted in https://reviews.llvm.org/rL280968 -- we should resolve https://reviews.llvm.org/D23931 before attempting to land again. https://reviews.llvm.org/D23932 __

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-07 Thread Dean Michael Berris via cfe-commits
dberris closed this revision. dberris added a comment. This has been landed as https://reviews.llvm.org/rL280889. https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-07 Thread Dean Michael Berris via cfe-commits
dberris added a comment. Landing this one now. https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-07 Thread Serge Rogatch via cfe-commits
rSerge added a comment. I don't have commit access rights. Could someone commit? https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-08-28 Thread Dean Michael Berris via cfe-commits
dberris accepted this revision. dberris added a comment. Concur 100% with @rengolin here -- please land after the LLVM changes land. :) https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-08-26 Thread Renato Golin via cfe-commits
rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. If this works without the other two patches, it's reasonably unrelated and harmless, and should be ok as soon as the other two patches are approved. Not because it's wrong, just because we

[PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-08-26 Thread Serge Rogatch via cfe-commits
rSerge created this revision. rSerge added reviewers: dberris, rengolin. rSerge added a subscriber: cfe-commits. Herald added subscribers: dberris, samparker, rengolin, aemerson. Just a test for now, adapted from x86_64 tests of XRay. https://reviews.llvm.org/D23932 Files: test/CodeGen/xray-at