This revision was automatically updated to reflect the committed changes.
Closed by commit rL280699: [OpenCL] Remove access qualifiers on images in arg
info metadata. (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23915?vs=69649&id=70372#toc
Repository:
rL LLVM
http
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
https://reviews.llvm.org/D23915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
https://reviews.llvm.org/D23915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etyurin updated this revision to Diff 69649.
etyurin added a comment.
Applied comments from Sam.
https://reviews.llvm.org/D23915
Files:
lib/CodeGen/CodeGenFunction.cpp
test/CodeGenOpenCL/kernel-arg-info.cl
Index: test/CodeGenOpenCL/kernel-arg-info.cl
===
yaxunl added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:439
@@ -438,1 +438,3 @@
+static void removeImageAccessQualifier(std::string& tyName) {
+ std::string roQual("__read_only");
variable names should be capitalized
http://llvm.org/docs/Cod
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
etyurin created this revision.
etyurin added reviewers: Anastasia, bader, yaxunl.
etyurin added a subscriber: cfe-commits.
Remove access qualifiers on images in arg info metadata:
* kernel_arg_type
* kernel_arg_base_type
Image access qualifiers are inseparable from type in clang implementation,
