Re: [PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

2016-08-28 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r279935 https://reviews.llvm.org/D23878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

2016-08-25 Thread Shoaib Meenai via cfe-commits
smeenai updated this revision to Diff 69275. smeenai added a comment. Using attributes instead of compile flags, per compnerd's suggestion https://reviews.llvm.org/D23878 Files: test/backtrace_test.pass.cpp Index: test/backtrace_test.pass.cpp =

Re: [PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

2016-08-25 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. I think it would be better to use `assert(true)` to avoid the TCO from kicking in. https://reviews.llvm.org/D23878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

2016-08-25 Thread Shoaib Meenai via cfe-commits
smeenai created this revision. smeenai added reviewers: compnerd, EricWF, rsmith. smeenai added a subscriber: cfe-commits. When we're running tests under ASAN or MSAN, they're compiled with -O1, which enables tail call elimination. This causes backtrace_test to fail: the compiler performs tail cal