Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-29 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r280015 https://reviews.llvm.org/D23856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-29 Thread Shoaib Meenai via cfe-commits
smeenai marked an inline comment as done. smeenai added a comment. https://reviews.llvm.org/D23856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-29 Thread Shoaib Meenai via cfe-commits
smeenai updated this revision to Diff 69607. smeenai added a comment. Putting -nodefaultlibs in CMAKE_REQUIRED_FLAGS https://reviews.llvm.org/D23856 Files: cmake/Modules/CheckLibcxxAtomic.cmake cmake/config-ix.cmake Index: cmake/config-ix.cmake =

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-29 Thread Shoaib Meenai via cfe-commits
smeenai added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) EricWF wrote: > smeenai wrote: > > smeenai wrote: > > > compne

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-29 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) smeenai wrote: > smeenai wrote: > > compnerd wrote: > > > Can w

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-29 Thread Shoaib Meenai via cfe-commits
smeenai marked an inline comment as done. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) smeenai wrote: > compnerd wrote: > > Can we not use

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-26 Thread Shoaib Meenai via cfe-commits
smeenai added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) compnerd wrote: > Can we not use `CMAKE_SHARED_LINKER_FLAGS` i

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-26 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) Can we not use `CMAKE_SHARED_LINKER_FLAGS` instead of `CMAKE

[PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

2016-08-24 Thread Shoaib Meenai via cfe-commits
smeenai created this revision. smeenai added reviewers: EricWF, compnerd. smeenai added subscribers: cfe-commits, kastiglione. We're compiling libc++ with -nodefaultlibs, so we should also pass this option during the configuration checks to ensure those checks are consistent with the actual build.