rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
I don't know how I missed this. Thanks for the patch!!!
https://reviews.llvm.org/D23855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 279744
https://reviews.llvm.org/D23855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sebpop accepted this revision.
sebpop added a comment.
This revision is now accepted and ready to land.
Very nice cleanup.
Maybe you can move some more #ifdefs into __throw_* functions, although as is
LGTM.
Thanks!
https://reviews.llvm.org/D23855
_
mclow.lists added inline comments.
Comment at: src/thread.cpp:59
@@ -58,1 +58,3 @@
throw system_error(error_code(ec, system_category()), "thread::join
failed");
+#else
+if (ec)
Need to fix these, too.
https://reviews.llvm.org/D23855
mclow.lists added inline comments.
Comment at: include/stdexcept:174
@@ -173,1 +173,3 @@
+// in the dylib
+_LIBCPP_BEGIN_NAMESPACE_STD
This comment belongs to `__throw_runtime_error`
https://reviews.llvm.org/D23855
__
mclow.lists updated this revision to Diff 69201.
mclow.lists added a comment.
I like this revision better; I need to check, but I think this hits all the
exception classes.
Goal: Every exception class in the standard should have a `VSTD::__throw_XXX`
function, marked `_LIBCPP_NORETURN inline _L
sebpop added a comment.
I like the patch.
Thanks for removing #ifdefs from the code: it improves readability in general.
Would it be possible to move the __throw_* functions in a same .h file to avoid
having them all over?
Comment at: include/array:212
@@ -214,3 +211,3 @@
#els
mclow.lists created this revision.
mclow.lists added reviewers: EricWF, hiraditya, kparzysz.
mclow.lists added a subscriber: cfe-commits.
This is a follow on to D21232, which marked a bunch of exception-throwing
helper routines as `noreturn`.
Now, make them really never return. Either they thro
