This revision was automatically updated to reflect the committed changes.
Closed by commit rL280118: Fix colored diagnostics from tools (authored by
ogoffart).
Changed prior to commit:
https://reviews.llvm.org/D23837?vs=69225&id=69725#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23837
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
https://reviews.llvm.org/D23837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
ogoffart added a comment.
Ping
https://reviews.llvm.org/D23837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart updated this revision to Diff 69225.
ogoffart added a comment.
This new patch make sure the test run fine as part of the testsuite, where the
output is not a terminal and the color are disabled by default
https://reviews.llvm.org/D23837
Files:
lib/Tooling/Tooling.cpp
unittests/Too
ogoffart updated this revision to Diff 69221.
ogoffart added a comment.
Added a test.
https://reviews.llvm.org/D23837
Files:
lib/Tooling/Tooling.cpp
unittests/Tooling/ToolingTest.cpp
Index: unittests/Tooling/ToolingTest.cpp
==
bruno added a comment.
Hi Olivier,
Can you add a test? Can you also include some context to the patch?
Thanks,
https://reviews.llvm.org/D23837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
ogoffart created this revision.
ogoffart added reviewers: bruno, dexonsmith, cfe-commits.
Herald added a subscriber: klimek.
r271042 changed the way the diagnostic arguments are parsed. It assumes that
the diagnostics options were already parsed by the "Driver".
For tools using clang::Tooling, the
