[PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

EricWF resigned from this revision. EricWF removed a reviewer: EricWF. EricWF added a comment. Resigning as a reviewer since this revision is dead. https://reviews.llvm.org/D23831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. False alarm. I figured out that only -Wattributes warnings ignore gcc system_header pragma. So this -Wcast-qual and other warnings doesn't block us. https://reviews.llvm.org/D23831 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. > ! In https://reviews.llvm.org/D23831#528668, @EricWF wrote: > > Are you also compiling with `-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER`? No. Libc++ buildbots doesn't set this option either and we do see warnings there. So the pragma doesn't help with compiling libc++

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

EricWF added a comment. In https://reviews.llvm.org/D23831#528666, @halyavin wrote: > We have libc++ in our source tree and compile it as part of our build > process. All code in the source tree uses -Werror by default, so I am having > compile errors on gcc 4.9. Are you also compiling with `

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. We have libc++ in our source tree and compile it as part of our build process. All code in the source tree uses -Werror by default, so I am having compile errors on gcc 4.9. https://reviews.llvm.org/D23831 ___ cfe-commits

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

EricWF added a comment. The reason I'm dragging my feet on this patch is I'm not sure the two formulations are *exactly* equivalent. I need to re-read the standard to be sure. What's the motivation for fixing a warning which libc++ never tests against? Normally the headers are treated as syste

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

EricWF added a comment. In https://reviews.llvm.org/D23831#528637, @halyavin wrote: > Thank you for fixing most of warnings. Now it says "cc1plus: warning: > unrecognized command line option "-Wno-c++14-compat"" though. No worries, it was driving me nuts. The addition of `-Wno-c++14-compat` an

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. Thank you for fixing most of warnings. Now it says "cc1plus: warning: unrecognized command line option "-Wno-c++14-compat"" though. https://reviews.llvm.org/D23831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. ping. https://reviews.llvm.org/D23831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits