This revision was automatically updated to reflect the committed changes.
Closed by commit rL280120: Basic/Targets.cpp: Add polaris10 and polaris11 gpus
(authored by olesalscheider).
Changed prior to commit:
https://reviews.llvm.org/D23746?vs=69485&id=69730#toc
Repository:
rL LLVM
https://r
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D23746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
olesalscheider updated this revision to Diff 69485.
https://reviews.llvm.org/D23746
Files:
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
===
--- lib/Basic/Targets.cpp
+++ lib/Basic/Targets.cpp
@@ -2110,21 +2110,23 @@
sta
olesalscheider added inline comments.
Comment at: lib/Basic/Targets.cpp:1959
@@ -1959,1 +1958,3 @@
+GK_VOLCANIC_ISLANDS,
+GK_ARCTIC_ISLANDS
} GPU;
arsenm wrote:
> tstellarAMD wrote:
> > We're trying to move to more descriptive GPU family names, so this
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:1959
@@ -1959,1 +1958,3 @@
+GK_VOLCANIC_ISLANDS,
+GK_ARCTIC_ISLANDS
} GPU;
tstellarAMD wrote:
> We're trying to move to more descriptive GPU family names, so this should be
> GK_GFX8 inste
tstellarAMD requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets.cpp:1959
@@ -1959,1 +1958,3 @@
+GK_VOLCANIC_ISLANDS,
+GK_ARCTIC_ISLANDS
} GPU;
We're trying to move to more descriptive GPU fami
olesalscheider updated this revision to Diff 68779.
https://reviews.llvm.org/D23746
Files:
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
===
--- lib/Basic/Targets.cpp
+++ lib/Basic/Targets.cpp
@@ -1955,7 +1955,8 @@
GK_CA
olesalscheider created this revision.
olesalscheider added reviewers: cfe-commits, tstellarAMD, arsenm.
https://reviews.llvm.org/D23746
Files:
lib/Basic/Targets.cpp
Index: lib/Basic/Targets.cpp
===
--- lib/Basic/Targets.cpp
+++ li
