Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279494: Fix style in some Clang-tidy checks documentation. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23728?vs=68933&id=68941#toc Repository: rL LLVM https://rev

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D23728#522710, @Eugene.Zelenko wrote: > Address review comment. Thanks! Still LG. Repository: rL LLVM https://reviews.llvm.org/D23728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko updated this revision to Diff 68933. Eugene.Zelenko added a comment. Address review comment. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-i

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For out-of-bounds checking of static -arrays, see the clang-diagnostic-array-bounds check. +arrays, se

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For out-of-bounds checking of static -arrays, see the clang-diagnostic-array-bounds check. +ar

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko updated this revision to Diff 68921. Eugene.Zelenko added a comment. Address review comments. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a few nits. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:9 @@ -8,3 +8,3 @@ are out of bounds (for ``std::array``). For ou

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko updated this revision to Diff 68908. Eugene.Zelenko added a comment. Address review comments. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-global-names-

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-22 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Please rebase your patch, I've made some changes to some of these files. Comment at: docs/clang-tidy/checks/misc-misplaced-widening-cast.rst:39 @@ -34,3 +38,3 @@ Forgetting to place the cast at all is at least as dangerous and at least as -common as misp

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-20 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:11 @@ -10,3 +10,3 @@ -The check can generate fixes after the option `GslHeader` has been set +The c

[PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-19 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: alexfh. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: nemanjai. Repository: rL LLVM https://reviews.llvm.org/D23728 Files: docs/