This revision was automatically updated to reflect the committed changes.
Closed by commit rL280998: [Driver] Report invalid -mtune/-mcpu parameters when
-arch=arm64 (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D23643?vs=68747&id=70761#toc
Repository:
rL LLVM
htt
ahatanak accepted this revision.
ahatanak added a reviewer: ahatanak.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM. We should fix this longstanding bug.
https://reviews.llvm.org/D23643
___
cfe-commits mailing list
vsk added a comment.
Ping.
https://reviews.llvm.org/D23643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk updated this revision to Diff 68747.
vsk added a comment.
- Specify a target per Tim's comments. This now passes 'check-clang' on Ubuntu
Xenial.
https://reviews.llvm.org/D23643
Files:
lib/Driver/Tools.cpp
test/Driver/arm-cortex-cpus.c
Index: test/Driver/arm-cortex-cpus.c
=
t.p.northover added inline comments.
Comment at: test/Driver/arm-cortex-cpus.c:306
@@ -305,2 +305,3 @@
// RUN: %clang -target arm -mcpu=bogus -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-BOGUS-CPU %s
+// RUN: %clang -arch arm64 -mcpu=bogus -### -c %s 2>&1 | FileCheck
-check-
vsk updated this revision to Diff 68630.
vsk added a comment.
Per Akira's suggestion, don't pretend that the Arg* for -arch is a
user-specified CPU name (and update the doxygen to reflect this).
https://reviews.llvm.org/D23643
Files:
lib/Driver/Tools.cpp
test/Driver/arm-cortex-cpus.c
Inde
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
-
ahatanak added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
-
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked by checking the target triple instead?
- if (Args.getLastArg(options::OPT_arch))
+ if ((A = Args.getLastArg(options::OPT_arch)))
return "cyclone";
-
ahatanak added a subscriber: ahatanak.
ahatanak added a comment.
Thanks Vedant, this also fixes the crash that occurs when -mtune=native is
provided.
https://reviews.llvm.org/D14471.
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
// FIXME: Should this be picked
vsk created this revision.
vsk added reviewers: t.p.northover, rengolin.
vsk added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
Fix a crash-on-invalid in which -mtune/-mcpu are set to nonsense values while
-arch=arm64.
This patch extends an arm cortex test
12 matches
Mail list logo
