Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh added a comment. In https://reviews.llvm.org/D23585#517942, @aaron.ballman wrote: > I've commit in r278926. (I can't close because @alexfh hasn't accepted yet; > Alex, can you accept & close?) Sure. Done. BTW, Phabricator can close revisions automatically on commit: http://llvm.org/do

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman added a comment. I've commit in r278926. (I can't close because @alexfh hasn't accepted yet; Alex, can you accept & close?) https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg added a comment. Thank you for the review. I don't have commit access, would you commit this for me, please? Thanks! https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg updated this revision to Diff 68340. thegameg added a comment. Update documentation according to @aarnon.ballman's remarks. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unit

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg marked an inline comment as done. thegameg added a comment. https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5490-5497 @@ +5489,10 @@ +/// +/// From clang/Basic/Linkage.h: +/// > UniqueExternalLinkage: +/// > External linkage within a unique namespace. +/// > From the language perspective, these enti

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg added a subscriber: alexfh. thegameg updated this revision to Diff 68332. thegameg added a comment. LibASTMatchersReference.html regenerated using `dump_ast_matchers.py`. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/LibASTMatchersReference.html:2774 @@ -2773,1 +2773,3 @@ +MatcherNamedDecl>hasExternalFormalLinkage +Matches N

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg marked an inline comment as done. thegameg added a comment. https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg updated this revision to Diff 68288. thegameg added a comment. Mention UniqueExternalLinkage type, add a test according to it. `EXPECT_FALSE(matches(` -> `EXPECT_TRUE(notMatches(` https://reviews.llvm.org/D23585 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/A

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg updated this revision to Diff 68290. thegameg added a comment. Sorry, sent the wrong patch. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersNar

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg marked an inline comment as done. thegameg added a comment. https://reviews.llvm.org/D23585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. A few minor nits, but thank you for the patch! Comment at: include/clang/ASTMatchers/ASTMatchers.h:5481 @@ +5480,3 @@ +/// +/// Example matches only z (

[PATCH] D23585: [ASTMatchers] Add narrowing matcher: hasExternalFormalLinkage

thegameg created this revision. thegameg added reviewers: bkramer, alexfh, hokein. thegameg added a subscriber: cfe-commits. Herald added a subscriber: klimek. Matches NamedDecl nodes whose linkage is external. https://reviews.llvm.org/D23585 Files: docs/LibASTMatchersReference.html include/