Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

2016-08-16 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278838: Remove excessive padding from LineNoCacheTy (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D23546?vs=68153&id=68240#toc Repository: rL LLVM https://reviews.llvm.org/D23

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

2016-08-16 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. Thanks, no, i don't. I will be grateful to you if you land this patch. https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

2016-08-16 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good, thanks. Do you have commit access? https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

2016-08-16 Thread Chris Lattner via cfe-commits
lattner resigned from this revision. lattner removed a reviewer: lattner. lattner added a comment. Seems obvious to me, but it would be best to find another reviewer, I haven't worked on this code for some time. https://reviews.llvm.org/D23546 ___

Re: [PATCH] D23546: Remove excessive padding from LineNoCacheTy

2016-08-16 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. F2274214: Screen Shot 2016-08-16 at 3.34.00 AM.png https://reviews.llvm.org/D23546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D23546: Remove excessive padding from LineNoCacheTy

2016-08-16 Thread Alexander Shaposhnikov via cfe-commits
alexshap created this revision. alexshap added a reviewer: lattner. alexshap added a subscriber: cfe-commits. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The struct LineNoCacheTy is in SourceMgr.cpp inside anonymous namespace. Th