Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

2016-08-15 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r278716. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

2016-08-15 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. Also LGTM. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

2016-08-15 Thread Michał Górny via cfe-commits
mgorny added a comment. Yes, I don't have commit access. However, Eric wanted to review it as well, so please don't commit it yet. https://reviews.llvm.org/D23507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D23507: [libcxx] include/math.h: Re-enable missing C++11 decls on SunOS

2016-08-15 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I can't vouch for the correctness (not having a sun system to play with), but this LGTM. at some point, the repeated expression `!(defined(_LIBCPP_MSVCRT) || defined(_AIX) || define