Re: [PATCH] D23480: Add a test for clang-tidy using the clang cl driver

2016-08-17 Thread Zachary Turner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278968: Add a test for clang-tidy using the clang-cl driver. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D23480?vs=67948&id=68413#toc Repository: rL LLVM https://reviews

Re: [PATCH] D23480: Add a test for clang-tidy using the clang cl driver

2016-08-13 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with two nits. > In order to get this to work, the positional arguments must use > --driver-mode=cl , and NOT clang-cl It's not that important for the fixed compilation database, as long

[PATCH] D23480: Add a test for clang-tidy using the clang cl driver

2016-08-12 Thread Zachary Turner via cfe-commits
zturner created this revision. zturner added a reviewer: alexfh. zturner added a subscriber: cfe-commits. In order to get this to work, the positional arguments must use `--driver-mode=cl `, and NOT `clang-cl `. In the latter case, clang-tidy has to try really hard to "guess" whether the first