rovka added a comment.
In https://reviews.llvm.org/D23054#503246, @rengolin wrote:
> All tests should have the target explicit, so I'd advocate for all of them to
> be changed.
Coming right up...
> Also, we need to make sure --target=x86_64 is enough on Windows. I remember
> some -target=arm
rengolin added a subscriber: rengolin.
rengolin added a comment.
All tests should have the target explicit, so I'd advocate for all of them to
be changed.
Also, we need to make sure --target=x86_64 is enough on Windows. I remember
some -target=arm not being enough (arm-eabi was enough, for some
rovka added a comment.
This seems to be the case for other similar tests as well (e.g.
cl-pch-errorhandling.cpp requires x86-registered-target, but doesn't force it
on the command line), but they're not currently crashing. I can update those as
well if people think it's the right thing to do.
rovka created this revision.
rovka added a reviewer: thakis.
rovka added subscribers: cfe-commits, hans.
Herald added a subscriber: aemerson.
These tests require x86-registered-target, but they don't force the target as
x86 on the command line, which means they will be run and they might fail when
