This revision was automatically updated to reflect the committed changes.
Closed by commit rL277433: [clang-rename] add basic Emacs integration (authored
by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23006?vs=66437&id=66442#toc
Repository:
rL LLVM
https://reviews.llvm.org/
alexfh accepted this revision.
alexfh added a comment.
LG
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Thanks! Fixed.
Waiting few more hours just in case anyone will jump in and write few comments.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
omtcyfz updated this revision to Diff 66437.
omtcyfz added a comment.
- s/print/type
- Add `clang-rename.py` to the `CMakeLists.txt` installation instructions.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/CMakeLists.txt
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
lgtm with two nits.
Comment at: clang-rename/tool/CMakeLists.txt:14
@@ +13,3 @@
+
+install(PROGRAMS clang-rename.el
+ DESTINATION share/clang
Also include th
omtcyfz added a comment.
In https://reviews.llvm.org/D23006#502814, @Eugene.Zelenko wrote:
> Please add install rule for clang-rename.el. See clang-format CMakeLists.txt
> as example.
Good point! Thank you!
Done.
https://reviews.llvm.org/D23006
___
omtcyfz updated this revision to Diff 66434.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/CMakeLists.txt
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clang-renam
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please add install rule for clang-rename.el. See clang-rename CMakeLists.txt as
example.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lis
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz marked 2 inline comments as done.
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+(orig-buf (current-buffer))
+(file-name (buffer-file-name)))
+
alexfh wrote:
> For posterity, please add a short summary of the offline discussi
omtcyfz updated this revision to Diff 66341.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clang-rename.rst
+++ docs/clang-rename.rst
@@
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+(orig-buf (current-buffer))
+(file-name (buffer-file-name)))
+
For posterity, please add a short summary of the offline discussion.
Commen
omtcyfz added a comment.
All the comments seem to be addressed.
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 66328.
omtcyfz marked 8 inline comments as done.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clan
omtcyfz added inline comments.
Comment at: clang-rename/tool/clang-rename.el:20
@@ +19,3 @@
+ "Rename all instances of the symbol at the point using clang-rename"
+ (interactive "sEnter a new name: ")
+ (let (;; Emacs offset is 1-based.
hokein wrote:
> `s` is a
alexfh added inline comments.
Comment at: clang-rename/tool/clang-rename.el:18
@@ +17,3 @@
+
+(defun clang-rename-upstream (new-name)
+ "Rename all instances of the symbol at the point using clang-rename"
The name should be just "clang-rename".
hokein added inline comments.
Comment at: clang-rename/tool/clang-rename.el:16
@@ +15,3 @@
+
+(defvar clang-rename-binary "clang-rename")
+
I think we should make `clang-rename` binary path configurable by making it a
custom variable (using `defcustom`).
===
omtcyfz added a comment.
Manuel, any other comments? Jens seems to be missing and I don't know about
anyone else who is familiar with Emacs :(
https://reviews.llvm.org/D23006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
omtcyfz updated this revision to Diff 66296.
omtcyfz marked 2 inline comments as done.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
===
--- docs/clan
omtcyfz added inline comments.
Comment at: clang-rename/tool/clang-rename.el:7
@@ +6,3 @@
+
+;; This package allows to filter code through clang-format to fix its
formatting.
+;; clang-format is a tool that formats C/C++/Obj-C code according to a set of
klimek wr
klimek added inline comments.
Comment at: clang-rename/tool/clang-rename.el:7
@@ +6,3 @@
+
+;; This package allows to filter code through clang-format to fix its
formatting.
+;; clang-format is a tool that formats C/C++/Obj-C code according to a set of
s/clang-fo
omtcyfz updated this revision to Diff 66292.
omtcyfz added a comment.
Update docs by adding information about Emacs integration.
https://reviews.llvm.org/D23006
Files:
clang-rename/tool/clang-rename.el
docs/clang-rename.rst
Index: docs/clang-rename.rst
=
omtcyfz created this revision.
omtcyfz added reviewers: bkramer, alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
This patch aims to add very basic Emacs integration. My experience with Emacs
is limited to few days, so I'm not sure whether I've done things correctly.
https://reviews.llvm
23 matches
Mail list logo
