[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2017-01-30 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-11-18 Thread Alexey Bataev via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D22955#598081, @rnk wrote: > If I understand correctly, this patch takes template function patterns, > copies them into instantiated context, parses them in that context, and then > instantiates them in that context. The key difference is tha

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-11-16 Thread Reid Kleckner via cfe-commits
rnk added a comment. If I understand correctly, this patch takes template function patterns, copies them into instantiated context, parses them in that context, and then instantiates them in that context. The key difference is that today's fdelayed-template-parsing doesn't parse the body of the

Re: [PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-11-16 Thread Will Wilson via cfe-commits
A backup ping. Sorry for the noise but this would be a very useful patch to get done and dusted. On 10 November 2016 at 08:17, Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ABataev added a comment. > > Ping > > > https://reviews.llvm.org/D22955 > > > > _

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-11-09 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-11-02 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ping! https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-10-14 Thread Alexey Bataev via cfe-commits
ABataev added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1044-1070 +static bool isBaseClass(const CXXRecordDecl *Record, CXXRecordDecl *Base) { + SmallVector Queue; + + while (true) { +for (const auto &I : Record->bases()) { + const RecordType *Ty = I.getType

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-10-12 Thread David Majnemer via cfe-commits
majnemer added inline comments. Comment at: lib/Sema/SemaLookup.cpp:1044-1070 +static bool isBaseClass(const CXXRecordDecl *Record, CXXRecordDecl *Base) { + SmallVector Queue; + + while (true) { +for (const auto &I : Record->bases()) { + const RecordType *Ty = I.getTyp

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-10-12 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-08-08 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ping https://reviews.llvm.org/D22955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-07-28 Thread Alexey Bataev via cfe-commits
ABataev created this revision. ABataev added reviewers: rnk, rsmith, majnemer. ABataev added subscribers: cfe-commits, andreybokhanko. MSVC actively uses unqualified lookup in dependent bases, lookup at the instantiation point (non-dependent names may be resolved on things declared later) etc. a