mstorsjo abandoned this revision.
mstorsjo added a comment.
This test isn't strictly necessary, thus abandoning
https://reviews.llvm.org/D22857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rengolin added a comment.
Ok, sounds good. Feel free to abandon this one as well.
cheers,
--renato
https://reviews.llvm.org/D22857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added a comment.
In https://reviews.llvm.org/D22857#497719, @rengolin wrote:
> I'll just echo @compnerd comments, since Phab didn't get it.
>
> - Change the syntax to __asm__, to be more portable
> - Add Microsoft asm block syntax
MSVC doesn't support inline assembly on ARM at all (the
rengolin added a comment.
In https://reviews.llvm.org/D22857#497805, @ahatanak wrote:
> Is r276859 fixing a bug in the assembler?
Sort of. It was just adding a comment character to ; instead of #.
> I'm trying to understand why we have to add a clang test in this particular
> case because I d
ahatanak added a subscriber: ahatanak.
ahatanak added a comment.
Is r276859 fixing a bug in the assembler?
I'm trying to understand why we have to add a clang test in this particular
case because I don't think we normally add a test in clang every time we fix a
bug in the backend or assembler.
rengolin requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/CodeGen/arm-inline-asm-windows.c:2
@@ +1,3 @@
+// REQUIRES: arm-registered-target
+// RUN: %clang -target armv7-windows -c -o - %s
+
Also, I just noticed,
rengolin added a subscriber: compnerd.
rengolin added a comment.
I'll just echo @compnerd comments, since Phab didn't get it.
- Change the syntax to __asm__, to be more portable
- Add Microsoft asm block syntax
cheers,
--renato
https://reviews.llvm.org/D22857
___
On Wed, Jul 27, 2016 at 5:53 AM, Martin Storsjö
wrote:
> mstorsjo created this revision.
> mstorsjo added a subscriber: cfe-commits.
> Herald added subscribers: samparker, rengolin, aemerson.
>
> This test uses an immediate constant, which was previously broken in
> inline assembly, prior to LLVM
mstorsjo created this revision.
mstorsjo added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson.
This test uses an immediate constant, which was previously broken in inline
assembly, prior to LLVM r276859.
https://reviews.llvm.org/D22857
Files:
test/CodeGen/
