This revision was automatically updated to reflect the committed changes.
Closed by commit rL278018: [analyzer] Change -analyze-function to accept
qualified names. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22856?vs=66360&id=67180#toc
Repository:
rL LLVM
htt
NoQ updated this revision to Diff 66360.
NoQ added a comment.
Copy-paste the code from CGDebugInfo.cpp to support Objective-C instance and
class methods. Add more tests. Move the `analyze_display_progress.cpp` because
most tests use dashes in names.
https://reviews.llvm.org/D22856
Files:
li
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Since this is an improvement, it looks good to me. (Improving printing of ObjC
methods is a good add on, but not blocking..)
https://reviews.llvm.org/D22856
_
zaks.anna added a comment.
We'd definitely want the same routine in both: printing the name in
-analyzer-display-progress and be accepted by -analyze-function.
Looks like what ND->getQualifiedNameAsString() returns is not proper ObjC
syntax, but maybe it's fine for the debug feature? Even thoug
dcoughlin added a comment.
In https://reviews.llvm.org/D22856#497796, @NoQ wrote:
> > I think it would be better for fully-qualified Objective-C methods to be
> > specified with their Objective-C-style names. For example: "-[Test1
> > myMethodWithY:withX:]".
>
>
> Uhm, need to know more about t
NoQ added a comment.
> I think it would be better for fully-qualified Objective-C methods to be
> specified with their Objective-C-style names. For example: "-[Test1
> myMethodWithY:withX:]".
Uhm, need to know more about those. So i just print "`-[`", then
fully-qualified class name, then sel
dcoughlin added a comment.
I think it would be better for fully-qualified Objective-C methods to be
specified with their Objective-C-style names. For example: "-[Test1
myMethodWithY:withX:]". This would also remove the ambiguity when there are
class and instance methods with the same selector.
NoQ created this revision.
NoQ added a reviewer: zaks.anna.
NoQ added subscribers: dcoughlin, xazax.hun, a.sidorin, cfe-commits.
The `-analyze-function` option is very useful when debugging test failures,
especially when printing or viewing exploded graphs - with this option you no
longer need t
