aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0
hubert.reinterpretcast added inline comments.
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0) {
+ assert(Align != 0u);
Skew %= Align;
aaron.ballman wrote:
> Usual
aaron.ballman added inline comments.
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0) {
+ assert(Align != 0u);
Skew %= Align;
Usually preferred to put in && "ratio
hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: aaron.ballman, faisalv, rsmith.
hubert.reinterpretcast added a subscriber: cfe-commits.
This change adds `LLVM_CONSTEXPR` to functions selected as follows:
- the body is already valid under C++11 for a `constexpr
