This revision was automatically updated to reflect the committed changes.
Closed by commit rL286409: [Sema][NFC] Reset HasFallthroughStmt when clearing
FunctionScopeInfo (authored by epilk).
Changed prior to commit:
https://reviews.llvm.org/D22770?vs=65380&id=77399#toc
Repository:
rL LLVM
h
On Mon, Nov 7, 2016 at 11:44 AM, Alex Lorenz wrote:
> arphaman added a comment.
>
> I looked at the way `HasFallthroughStmt` is used, and it didn't seem so, no.
> It's used in the following manner in AnalysisBasedWarnings.cpp:
>
> bool FallThroughDiagFull =
> !Diags.isIgnored(diag::warn_u
arphaman added a comment.
I looked at the way `HasFallthroughStmt` is used, and it didn't seem so, no.
It's used in the following manner in AnalysisBasedWarnings.cpp:
bool FallThroughDiagFull =
!Diags.isIgnored(diag::warn_unannotated_fallthrough, D->getLocStart());
bool FallThroughDiag
aaron.ballman added a comment.
I don't suppose there's a testcase we could generate for this fix?
https://reviews.llvm.org/D22770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman accepted this revision.
arphaman added a reviewer: arphaman.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks.
https://reviews.llvm.org/D22770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
The FunctionScopeInfo stack in Sema uses an optimization where the memory for
the top-level functions is reused. The function FunctionScopeInfo::Clear() is
used to re
