EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
Looks like @mclow.lists just committed another version of this paper, so this
patch is no longer needed.
Resigning as reviewer.
https://reviews.llvm.org/D22584
lefticus marked an inline comment as done.
lefticus added a subscriber: EricFowler.
lefticus added a comment.
@EricFowler I have too many other things going on right now to be able to look
at it for at least the next few months.
https://reviews.llvm.org/D22584
___
EricWF added a comment.
@lefticus Are you still interested in working on this? If so could you please
split the changes for `array` into a separate patch? Marshall seems to have
implemented some of the changes in `` and that's causing merge
conflicts.
https://reviews.llvm.org/D22584
__
lefticus updated this revision to Diff 71668.
lefticus added a comment.
Add C++1z check around constexpr tests, based on mclow's feedback
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/a
mclow.lists added a comment.
Other than the iterator.primitives/iterator.operations/prev.pass.cpp test, I
think this is good to go.
Comment at:
test/std/iterators/iterator.primitives/iterator.operations/prev.pass.cpp:47
@@ +46,3 @@
+
+{
+constexpr const char* s = "
lefticus updated this revision to Diff 69195.
lefticus added a comment.
Address formatting concerns and out-of-date-ness of patch relative to
trunk/master
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/cont
mclow.lists added a comment.
This diff no longer applies cleanly, and I've added some formatting concerns.
However, the //content// looks fine to me.
Comment at: include/array:176
@@ -175,3 +175,3 @@
_LIBCPP_INLINE_VISIBILITY
-const_iterator cend() const _NOEXCEPT {re
lefticus added a comment.
I believe all or most of the "untested" comments are correctly tested in the
updated test files via static_asserts with contexpr. I've commented on just the
first one to make sure I understand correctly.
Comment at: include/array:156
@@ -155,3 +155,3
lefticus updated this revision to Diff 65398.
lefticus added a comment.
Correct context from last patch
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/array/begin.pass.cpp
test/std/con
lefticus added a comment.
I believe I messed up the context for the files, will attempt to resubmit the
patch.
https://reviews.llvm.org/D22584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
lefticus marked 3 inline comments as done.
lefticus added a comment.
https://reviews.llvm.org/D22584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lefticus updated this revision to Diff 65390.
lefticus added a comment.
Fixed syntax errors in test files.
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/array/begin.pass.cpp
test/std/
EricWF added a comment.
For the most part this LGTM. Thanks for putting in all this work. I've noted
some places where the test coverage could be improved.
Comment at: include/array:156
@@ -155,3 +155,3 @@
_LIBCPP_INLINE_VISIBILITY
-iterator begin() _NOEXCEPT {return i
lefticus retitled this revision from "C++1z constexpr support for array and
iterator" to "constexpr array support C++1z (P0031)".
lefticus updated the summary for this revision.
lefticus updated this revision to Diff 65143.
lefticus added a comment.
- Updated title and summary to be more accurate
14 matches
Mail list logo
