mgehre added a comment.
Friendly ping
https://reviews.llvm.org/D22476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre updated this revision to Diff 90592.
mgehre added a comment.
Updated fix for the crash in SemaChecking::RefersToMemberWithReducedAlignment,
so it also works for C code.
https://reviews.llvm.org/D22476
Files:
lib/AST/Expr.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaOverload.cpp
tes
mgehre added inline comments.
Comment at: lib/AST/Expr.cpp:1413
+for (auto *EnableIf : Method->specific_attrs()) {
+ if (EnableIf->getCond()->isTypeDependent())
+return false;
rsmith wrote:
> You should presumably be checking `isValueDependent` h
mgehre updated this revision to Diff 90591.
mgehre marked 4 inline comments as done.
mgehre added a comment.
Thanks for your comments! I'm very sorry for the huge delay. I have now more
time to work on this.
I added all your comments to the commit
and fixed a crash in SemaChecking::RefersToMember
rsmith added inline comments.
Comment at: lib/AST/Expr.cpp:1413
@@ +1412,3 @@
+for (auto *EnableIf : Method->specific_attrs()) {
+ if (EnableIf->getCond()->isTypeDependent())
+return false;
You should presumably be checking `isValueDependent` here
mgehre added a comment.
ping
https://reviews.llvm.org/D22476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre updated this revision to Diff 64777.
mgehre added a comment.
- Properly check for being member of current instantiation.
- Add new testcase test/CXX/temp/temp.res/temp.dep/temp.dep.expr/p5.cpp
- Added assert() according to review comment
https://reviews.llvm.org/D22476
Files:
lib/AST/E
rsmith added inline comments.
Comment at: lib/AST/Expr.cpp:1425
@@ +1424,3 @@
+
+ if (E->isTypeDependent() && isa(base)) {
+bool MemberOfCurrentInstantiation = true;
The language rule for this says nothing about the base being a `this`
expression; there are
mgehre created this revision.
mgehre added reviewers: klimek, aaron.ballman, rsmith.
mgehre added a subscriber: cfe-commits.
A MemberExpr is non-dependent if
1) it is a member of the current instantiation
2) the member is non-dependent
We check 1) by asserting that the base of the
MemberExpr is a
