This revision was automatically updated to reflect the committed changes.
Closed by commit rL277522: [CFG] Fix crash finding destructor of
lifetime-extended temporary. (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D22419?vs=65545&id=66554#toc
Repository:
rL LLVM
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. I will commit. Thanks Nandor!
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
nandor added a comment.
ping
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nandor added a comment.
I'm not an expert in temporaries either, I think for a proper fix a lot more
work is required.
It seems that the problem is with locating destructors in destructor calls. I
get the impression that currently a destructor node pointing to the declaration
is added and the
nandor updated this revision to Diff 65545.
nandor marked an inline comment as done.
nandor added a comment.
removed redundant checks
https://reviews.llvm.org/D22419
Files:
lib/Analysis/CFG.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-thread-safety-analysis.cpp
NoQ added a comment.
Thanks for working on this!
While i probably won't be of much help (no expert in temporaries yet), i notice
that this code piece (with `getReferenceInitTemporaryType()`) seems to be
duplicated at least three times in this file, with slight variations and
FIXMEs. So i guess
nandor added a comment.
ping?
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
This is https://llvm.org/bugs/show_bug.cgi?id=28666
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nandor updated this revision to Diff 64368.
nandor added a comment.
Fixed typo
https://reviews.llvm.org/D22419
Files:
lib/Analysis/CFG.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-thread-safety-analysis.cpp
==
