Re: [PATCH] D22296: CodeGen: Attach !splitpoint metadata to vtables under Itanium ABI.

2016-07-26 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 65647. pcc added a comment. Use new representation: https://reviews.llvm.org/D22793 https://reviews.llvm.org/D22296 Files: include/clang/AST/VTableBuilder.h lib/AST/VTableBuilder.cpp lib/CodeGen/CGCXX.cpp lib/CodeGen/CGVTT.cpp lib/CodeGen/CGVTables.cp

Re: [PATCH] D22296: CodeGen: Attach !splitpoint metadata to vtables under Itanium ABI.

2016-07-18 Thread Peter Collingbourne via cfe-commits
pcc added a comment. > An amendment to the Itanium ABI requiring that a conforming program may not > adjust a virtual table pointer loaded from an object to another virtual table > in the same virtual table group would seem to be all that would be required > to guarantee that this scheme wil

[PATCH] D22296: CodeGen: Attach !splitpoint metadata to vtables under Itanium ABI.

2016-07-12 Thread Peter Collingbourne via cfe-commits
pcc created this revision. pcc added reviewers: rsmith, eugenis. pcc added subscribers: cfe-commits, krasin. pcc added a dependency: D22295: Introduce !splitpoint metadata and GlobalSplit pass.. This metadata can be used to annotate global variables with split points. Each split point specifies a