Re: [PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

2016-07-15 Thread Dave Bartolomeo via cfe-commits
DaveBartolomeo abandoned this revision. DaveBartolomeo added a comment. I'll attempt to fix the underlying issue https://llvm.org/bugs/show_bug.cgi?id=27098 instead. https://reviews.llvm.org/D22273 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

2016-07-12 Thread Reid Kleckner via cfe-commits
rnk added a comment. I think this is just a consequence of https://llvm.org/bugs/show_bug.cgi?id=27098 We should just fix the underlying bug so that `EnumDecl::isFixed()` doesn't return true for plain enums in C or C++ when targeting Windows. http://reviews.llvm.org/D22273

Re: [PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

2016-07-12 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer requested changes to this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision now requires changes to proceed. This requires an associated test case. Comment at: lib/Sema/SemaDecl.cpp:14354-14355

[PATCH] D22273: Treat enumerator_too_large as an extension in MS ABI mode

2016-07-12 Thread Dave Bartolomeo via cfe-commits
DaveBartolomeo created this revision. DaveBartolomeo added reviewers: rnk, cfe-commits. When compiling as C targeting the MS ABI, but with -fno-ms-compatibility, an enumerator initializer that is not representable as an int is treated as an error. This is correct according to the C standard, but