Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

2016-07-13 Thread Mandeep Singh Grang via cfe-commits
mgrang added a comment. Thanks Renato for your comments. I guess I will not upstream my patches then. --Mandeep http://reviews.llvm.org/D22254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

2016-07-13 Thread Renato Golin via cfe-commits
rengolin added a comment. In http://reviews.llvm.org/D22254#481972, @mgrang wrote: > Hi Tim/Renato, > > On a similar note, I have a patch which adds the breakpoint intrinsic (for > ARM and Thumb): > > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491c/CJAHBCFH.html Hi Mande

Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

2016-07-12 Thread Mandeep Singh Grang via cfe-commits
mgrang added a comment. Hi Tim/Renato, On a similar note, I have a patch which adds the breakpoint intrinsic (for ARM and Thumb): http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491c/CJAHBCFH.html Could you please let me know if this is something which the community would like

Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

2016-07-12 Thread Tim Northover via cfe-commits
t.p.northover added a comment. I agree with Renato too. It seems like, as a compiler, we can provide virtually no guarantees about the value of `__builtin_arm_current_pc`: it's not necessarily in the PC-range of the dynamically innermost frame (inlining); it's not necessarily even in the calls

Re: [PATCH] D22254: [ARM, AArch64] Adds builtins to get current SP and PC

2016-07-12 Thread Renato Golin via cfe-commits
rengolin requested changes to this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision now requires changes to proceed. Hi Weiming, We've discussed about creating builtins when I added support for named registers and the consensus was that, since there is alrea