Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-14 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275388: [clang-rename] add documentation (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D22129?vs=63646&id=63944#toc Repository: rL LLVM http://reviews.llvm.org/D22129 Files:

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-14 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D22129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-13 Thread Kirill Bobyrev via cfe-commits
omtcyf0 added a comment. Any other objections? http://reviews.llvm.org/D22129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-12 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63646. omtcyf0 marked 6 inline comments as done. omtcyf0 added a comment. Fixed. Thanks for the feedback! http://reviews.llvm.org/D22129 Files: docs/clang-rename.rst Index: docs/clang-rename.rst ==

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-11 Thread Ben Jackson via cfe-commits
puremourning added a subscriber: puremourning. puremourning added a comment. Couple of drive-by comments. Thanks for doing this. Comment at: docs/clang-rename.rst:45 @@ +44,3 @@ + +The tool is currently supporting renaming actions inside single Translation Unit +only. It is pla

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-11 Thread Benjamin Kramer via cfe-commits
bkramer added inline comments. Comment at: docs/clang-rename.rst:17 @@ +16,3 @@ + +The tool development is in very early stage, so you might encounter bugs and +crashes. Submitting reports with information about how to reproduce the issue maybe 'is in a very early

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-08 Thread Kirill Bobyrev via cfe-commits
omtcyf0 updated this revision to Diff 63202. omtcyf0 marked an inline comment as done. http://reviews.llvm.org/D22129 Files: docs/clang-rename.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/index.rst @@

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-08 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: docs/clang-rename.rst:13 @@ +12,3 @@ + +:program:`clang-rename` is a clang-based C++ "linter" tool. Its purpose is to +perform efficient renaming actions in large-scale projects such as renaming s/"linter"// http://revie

[PATCH] D22129: [clang-rename] add documentation

2016-07-08 Thread Kirill Bobyrev via cfe-commits
omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, ioeric, bkramer, klimek, hokein. omtcyf0 added a subscriber: cfe-commits. clang-rename needs at least to have a minimum documentation to provide a small introduction for new users http://reviews.llvm.org/D22129 Files: docs/clang-