Re: [PATCH] D21971: Explicitly export symbols from the sample analyzer plugin

2016-07-08 Thread John Brawn via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL274871: Explicitly export symbols from the sample analyzer plugin (authored by john.brawn). Changed prior to commit: http://reviews.llvm.org/D21971?vs=62674&id=63248#toc Repository: rL LLVM http://r

Re: [PATCH] D21971: Explicitly export symbols from the sample analyzer plugin

2016-07-08 Thread John Brawn via cfe-commits
john.brawn added a comment. > Do you known if there is any good reason Analyzer plugins aren't using the > Registry system (thus forcing plugin writers to manually export the > functions)? Your guess is as good as mine. Repository: rL LLVM http://reviews.llvm.org/D21971 ___

Re: [PATCH] D21971: Explicitly export symbols from the sample analyzer plugin

2016-07-08 Thread Rudy Pons via cfe-commits
Ilod added a comment. LGTM. Do you known if there is any good reason Analyzer plugins aren't using the Registry system (thus forcing plugin writers to manually export the functions)? Repository: rL LLVM http://reviews.llvm.org/D21971 ___ cfe-co

[PATCH] D21971: Explicitly export symbols from the sample analyzer plugin

2016-07-04 Thread John Brawn via cfe-commits
john.brawn created this revision. john.brawn added reviewers: Ilod, chapuni, ehsan, reames. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. This is done so that it will work when built using MSVC if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON. Repos