Committed in r277005
On Thu, Jul 28, 2016 at 9:38 AM Zachary Turner wrote:
> Sorry for the delay, I had forgotten about this. I will check it in today.
>
> On Wed, Jul 27, 2016 at 5:57 PM comicfans44 wrote:
>
>> comicfans44 added a comment.
>>
>> In https://reviews.llvm.org/D21946#473071, @ztu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277005: [Driver] Fix Windows SDK Detection (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D21946?vs=62570&id=65958#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21946
Sorry for the delay, I had forgotten about this. I will check it in today.
On Wed, Jul 27, 2016 at 5:57 PM comicfans44 wrote:
> comicfans44 added a comment.
>
> In https://reviews.llvm.org/D21946#473071, @zturner wrote:
>
> > In https://reviews.llvm.org/D21946#473070, @comicfans44 wrote:
> >
>
comicfans44 added a comment.
In https://reviews.llvm.org/D21946#473071, @zturner wrote:
> In https://reviews.llvm.org/D21946#473070, @comicfans44 wrote:
>
> > I've not commited to cfe before, so I think I havn't commit access
> > permission.
>
>
> If you've committed anywhere in LLVM, you should
comicfans44 added a comment.
neither did I commited to LLVM ... so I'll wait.
http://reviews.llvm.org/D21946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zturner added a comment.
In http://reviews.llvm.org/D21946#473070, @comicfans44 wrote:
> I've not commited to cfe before, so I think I havn't commit access permission.
If you've committed anywhere in LLVM, you should have commit access to cfe.
Feel free to give it a try, as I won't be able to
comicfans44 added a comment.
I've not commited to cfe before, so I think I havn't commit access permission.
http://reviews.llvm.org/D21946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good, do you have commit access to commit this?
http://reviews.llvm.org/D21946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
comicfans44 created this revision.
comicfans44 added reviewers: zturner, majnemer.
comicfans44 added a subscriber: cfe-commits.
1. readFullStringValue returns bool, should not compared with ERROR_SUCCESS
2. RegQueryValueExW string may contain null terminating char ,should be trimmed
these leads ge
