hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
sfantao updated this revision to Diff 75698.
sfantao marked 10 inline comments as done.
sfantao added a comment.
- Address Hal Finkel suggestions - rename functions/reorder code/fix comments.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index:
sfantao added a comment.
Hi Hal,
Thanks for the review!
In https://reviews.llvm.org/D21840#555719, @hfinkel wrote:
> The naming here is a bit hard to follow, we have 'dependent action',
> 'dependency action', 'depending action', and I think they're all supposed to
> mean the same thing. Only
hfinkel added a comment.
The naming here is a bit hard to follow, we have 'dependent action',
'dependency action', 'depending action', and I think they're all supposed to
mean the same thing. Only 'dependent action' sounds right to me, can we use
that universally (i.e. in all comments and names
ABataev added a comment.
LG for me
https://reviews.llvm.org/D21840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 72118.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.
sfantao updated this revision to Diff 66017.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.
sfantao updated this revision to Diff 63682.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.c
sfantao updated this revision to Diff 62575.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cp
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/Driver/Driver.cpp:2416
@@ +2415,3 @@
+ /// be collapsed with it.
+ struct JobActionInfoTy {
+// \brief The action this info refers to.
ABataev wrote:
> I think this can be marked '
sfantao updated this revision to Diff 62507.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Fix comments.
- Mark functions properly with const and static.
- Remove \brief.
http://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index:
ABataev added a comment.
General comment: remove '\brief' tags, they are not required anymore, just
'\\\' is enough
Comment at: include/clang/Driver/Action.h:94
@@ -93,1 +93,3 @@
+ /// \brief Flag that is set to true if this action can be collapsed with
+ /// others actions
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev, rsmith.
sfantao added subscribers: carlo.bertolli, arpith-jacob, caomhin,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
This creates a tool selector in the driver that
13 matches
Mail list logo
