Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Dean Michael Berris via cfe-commits
dberris added a comment. Changed the description to provide a justification. http://reviews.llvm.org/D21830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Rafael Espíndola via cfe-commits
On Wed, Jun 29, 2016, 17:43 Joerg Sonnenberger wrote: > On Wed, Jun 29, 2016 at 11:00:26AM -0400, Rafael Espíndola via cfe-commits > wrote: > > We need to benchmark this to see if it still makes a difference. > > > > My canonical test is the .s of a lto of clang. > > That won't exercise it? Assem

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 29, 2016 at 11:00:26AM -0400, Rafael Espíndola via cfe-commits wrote: > We need to benchmark this to see if it still makes a difference. > > My canonical test is the .s of a lto of clang. That won't exercise it? Assembler sources are exempt from this. Joerg _

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer added a comment. Why are you making this change? I cannot see a justification in the description. http://reviews.llvm.org/D21830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Rafael Espíndola via cfe-commits
We need to benchmark this to see if it still makes a difference. My canonical test is the .s of a lto of clang. Cheers, Rafael On 29 June 2016 at 03:37, Dean Michael Berris wrote: > dberris created this revision. > dberris added reviewers: echristo, rafael, grosbach. > dberris added a subscrib

[PATCH] D21830: Remove -mrelax-all from Clang -O0

2016-06-29 Thread Dean Michael Berris via cfe-commits
dberris created this revision. dberris added reviewers: echristo, rafael, grosbach. dberris added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Remove the -mrelax-all options passed onto the integrated assembler in -O0. http://reviews.llvm.org/D21830 Files: lib/Driver/Tool