Re: [PATCH] D21820: [libcxx] [test] Make swap_noexcept.pass.cpp tests more portable.

2016-07-24 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r276590. https://reviews.llvm.org/D21820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21820: [libcxx] [test] Make swap_noexcept.pass.cpp tests more portable.

2016-07-24 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'm not thrilled with this, but as you mentioned actually fixing this will be a lot of work. I opened a bug to track that work https://llvm.org/bugs/show_bug.cgi?id=28687. However for now this

[PATCH] D21820: [libcxx] [test] Make swap_noexcept.pass.cpp tests more portable.

2016-06-28 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make swap_noexcept.pass.cpp tests more portable. These tests define types like some_alloc, which dramatically fail to meet the allocator requirements. They don't even have all