alexfh added a comment.
Ping ;)
Do you have time to finish this?
https://reviews.llvm.org/D21815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/google/GlobalNamesInHeadersCheck.cpp:49
@@ -48,1 +48,3 @@
+namespace {
+std::string getIncludeFromMessage(SourceLocation DeclLoc,
Static functions are preferred in LLVM.
http://llvm.org/docs/CodingStandards.h
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Add 'included from' details to warning message to
google-global-names-in-headers.
It should make it clearer on those cases where a non-header is being mistakenly
#included.
http://reviews.llvm