Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274257: Don't instantiate a full host toolchain in ASTMatchersTest. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D21810?vs=62132&id=62385#toc Repository: rL LLVM http://rev

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D21810#471486, @jlebar wrote: > > But I think this is a reasonable workaround until such an API can be > > provided. > > > Should I take that as an LG, or are

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

jlebar added a comment. > But I think this is a reasonable workaround until such an API can be provided. Should I take that as an LG, or are we waiting for someone else to approve this? http://reviews.llvm.org/D21810 ___ cfe-commits mailing list c

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

jlebar updated this revision to Diff 62132. jlebar marked 3 inline comments as done. jlebar added a comment. Fix typo in comment. http://reviews.llvm.org/D21810 Files: unittests/ASTMatchers/ASTMatchersTest.h Index: unittests/ASTMatchers/ASTMatchersTest.h =

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

chandlerc added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83 @@ +80,5 @@ + // + // FIXME: This is a hack to work around the fact that there's no way to do the + // equivalent of runToolOnCodeWithArgs without instantiating a full Driver. + // We s

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

jlebar added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:81-83 @@ +80,5 @@ + // + // FIXME: This is a hack to work around the fact that there's no way to do the + // equivalent of runToolOnCodeWithArgs without instantiating a full Driver. + // We shou

Re: [PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

klimek added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTest.h:77 @@ +76,3 @@ + // Some tests need rtti/exceptions on. Use an unknown-unknown triple so we + // don't instantiate the full system toolchain. On Linux, instantiting the + // toolchain involves s

[PATCH] D21810: Don't instantiate a full host toolchain in ASTMatchersTest.

jlebar created this revision. jlebar added a reviewer: chandlerc. jlebar added a subscriber: cfe-commits. Herald added a subscriber: klimek. This test was stat()'ing large swaths of /usr/lib hundreds of times, as every invocation of matchesConditionally*() created a new Linux toolchain. In additi