Re: [PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-30 Thread Weiming Zhao via cfe-commits
weimingz added a comment. In http://reviews.llvm.org/D21706#471091, @EricWF wrote: > Please make the changes in the above comment. Sure. I'm working on it. Just got interrupted/distracted by other tasks time to time. :( http://reviews.llvm.org/D21706 __

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-29 Thread Eric Fiselier via cfe-commits
EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Please make the changes in the above comment. http://reviews.llvm.org/D21706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-24 Thread Eric Fiselier via cfe-commits
EricWF added a subscriber: EricWF. EricWF added reviewers: mclow.lists, EricWF. EricWF added a comment. We actually have a non-macro that does this. It's called `__libcpp_throw` and it lives in ``. Please use that instead. http://reviews.llvm.org/D21706 __

Re: [PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-24 Thread Weiming Zhao via cfe-commits
weimingz added a comment. Before replacing all throw/assert to macros, let's first check if we're on the right path. http://reviews.llvm.org/D21706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D21706: [libcxx] refactor for throw or assert

2016-06-24 Thread Weiming Zhao via cfe-commits
weimingz created this revision. weimingz added reviewers: rmaprath, grandinj. weimingz added a subscriber: cfe-commits. Add macros to wrapper for throw or assert. http://reviews.llvm.org/D21706 Files: include/__config include/__locale include/array include/experimental/optional include