mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 275819.
https://reviews.llvm.org/D21637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
elram added a comment.
I don't have commit access.
Can someone do it for me please?
https://reviews.llvm.org/D21637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
elram updated this revision to Diff 62339.
http://reviews.llvm.org/D21637
Files:
include/__mutex_base
Index: include/__mutex_base
===
--- include/__mutex_base
+++ include/__mutex_base
@@ -34,16 +34,20 @@
class _LIBCPP_TYPE_VIS
On Thu, Jun 30, 2016 at 06:37:59AM +, Eric Fiselier wrote:
> EricWF requested changes to this revision.
> EricWF added a comment.
> This revision now requires changes to proceed.
>
> C++03 does not support default member initializers but libc++ provides both
> of these classes an extensions i
rmaprath added a comment.
In http://reviews.llvm.org/D21637#471154, @EricWF wrote:
> In http://reviews.llvm.org/D21637#471151, @rmaprath wrote:
>
> > Small side question: so how are `__m_` and `__cv_` initialized in this
> > setup? is it that `pthread_mutex_lock()` and the like would be able to
EricWF added a comment.
In http://reviews.llvm.org/D21637#471151, @rmaprath wrote:
> Small side question: so how are `__m_` and `__cv_` initialized in this setup?
> is it that `pthread_mutex_lock()` and the like would be able to handle an
> un-initialized blob of memory (in a thread-safe way)?
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
Small side question: so how are `__m_` and `__cv_` initialized in this setup?
is it that `pthread_mutex_lock()` and the like would be able to handle an
un-initialized blob of memory (in a thread-safe way)? Because I don't see a
ca
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D21637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
C++03 does not support default member initializers but libc++ provides both of
these classes an extensions in C++03.
C++03 also does not support defaulted special members.
I think th
On Thu, Jun 23, 2016 at 02:27:12PM +, Ben Craig via cfe-commits wrote:
> bcraig added subscribers: joerg, bcraig.
> bcraig added a comment.
>
> @joerg. I think this has been fixed in newer versions of NetBSD.
>
> Sure would be nice if someone could fix this on the MUSL side of things.
>
> S
bcraig added subscribers: joerg, bcraig.
bcraig added a comment.
@joerg. I think this has been fixed in newer versions of NetBSD.
Sure would be nice if someone could fix this on the MUSL side of things.
See https://bugs.musicpd.org/view.php?id=4110 for fun conversations about
mutex, PTHREAD_MU
elram created this revision.
elram added a reviewer: EricWF.
elram added a subscriber: cfe-commits.
Some pthread implementations use volatile types in their structs.
C++11 does not allow initializing volatile types in constexpr constructors.
This fixes building libcxx on musl-libc and NetBSD.
h
12 matches
Mail list logo
