Re: [PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

2016-06-30 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: include-fixer/IncludeFixer.cpp:234 @@ +233,3 @@ + std::string MinimizedFilePath = minimizeInclude( + ((FilePath[0] == '"' || FilePath[0] == '<') ? FilePath + : "\"" + File

Re: [PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

2016-06-28 Thread Haojian Wu via cfe-commits
hokein added a comment. In http://reviews.llvm.org/D21603#468717, @djasper wrote: > Sorry, I completely forgot about this. Will try to review today. Is this part > about the patch description accurate? Yes, the description is accurate. > Specifically, what needs to be implemented in vim to ma

Re: [PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

2016-06-28 Thread Daniel Jasper via cfe-commits
djasper added a comment. Sorry, I completely forgot about this. Will try to review today. Is this part about the patch description accurate? "This version only fixes the first discovered unidentified symbol. In the long run, include-fixer should fix all unidentified symbols with a same name at o

Re: [PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

2016-06-22 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 61524. hokein added a comment. Fix a typo. http://reviews.llvm.org/D21603 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/SymbolIndexManager.cpp include-fixer/SymbolIndexManager.h include-fixer/find-all-symbo

[PATCH] D21603: [include-fixer] Fix namespace after inserting a missing header.

2016-06-22 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a subscriber: cfe-commits. This is an initial version of fixing namespace issues by adding a missing namespace prefix to an unidentified symbol. This version only fixes the first discovered unidentified symbol In the long run, include-fixer should fix al