Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-26 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273812: [X86] add _mm_loadu_si64 (authored by abadouh). Changed prior to commit: http://reviews.llvm.org/D21504?vs=61903&id=61912#toc Repository: rL LLVM http://reviews.llvm.org/D21504 Files: cfe/

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-26 Thread Simon Pilgrim via cfe-commits
RKSimon accepted this revision. RKSimon added a reviewer: RKSimon. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D21504 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-26 Thread Asaf Badouh via cfe-commits
AsafBadouh updated this revision to Diff 61903. Repository: rL LLVM http://reviews.llvm.org/D21504 Files: tools/clang/lib/Headers/emmintrin.h tools/clang/test/CodeGen/sse2-builtins.c Index: tools/clang/lib/Headers/emmintrin.h ===

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-23 Thread Craig Topper via cfe-commits
craig.topper added a subscriber: craig.topper. Comment at: tools/clang/test/CodeGen/sse2-builtins.c:1526 @@ +1525,3 @@ + // CHECK-LABEL: test_mm_loadu_si64 + // CHECK: load i64, i64* %{{.*}}, align 1 + // CHECK: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-23 Thread Asaf Badouh via cfe-commits
AsafBadouh updated this revision to Diff 61661. AsafBadouh added a comment. add align to CHECK Repository: rL LLVM http://reviews.llvm.org/D21504 Files: tools/clang/lib/Headers/emmintrin.h tools/clang/test/CodeGen/sse2-builtins.c Index: tools/clang/lib/Headers/emmintrin.h ==

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-22 Thread Simon Pilgrim via cfe-commits
RKSimon added inline comments. Comment at: tools/clang/test/CodeGen/sse2-builtins.c:1526 @@ +1525,3 @@ + // CHECK-LABEL: test_mm_loadu_si64 + // CHECK: load i64, i64* %__u + // CHECK: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 Please can add the alignmen

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-19 Thread Asaf Badouh via cfe-commits
AsafBadouh updated this revision to Diff 61200. AsafBadouh added a comment. small changes according to Simon review. Repository: rL LLVM http://reviews.llvm.org/D21504 Files: tools/clang/lib/Headers/emmintrin.h tools/clang/test/CodeGen/sse2-builtins.c Index: tools/clang/lib/Headers/emmi

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-19 Thread Simon Pilgrim via cfe-commits
RKSimon added a subscriber: RKSimon. Comment at: tools/clang/test/CodeGen/sse2-builtins.c:1527 @@ +1526,3 @@ + // CHECK: load i64, i64* %__u + // CHECK: insertelement <2 x i64> undef, i64 %4, i32 0 + // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 Repla

[PATCH] D21504: [X86] add _mm_loadu_si64

2016-06-19 Thread Asaf Badouh via cfe-commits
AsafBadouh created this revision. AsafBadouh added reviewers: delena, igorb, m_zuckerman. AsafBadouh added a subscriber: cfe-commits. AsafBadouh set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D21504 Files: tools/clang/lib/Headers/emmintrin.h to