This revision was automatically updated to reflect the committed changes.
Closed by commit rL285883: Fix heuristics skipping invalid ctor-initializers
with C++11 (authored by ogoffart).
Changed prior to commit:
https://reviews.llvm.org/D21502?vs=69223&id=76819#toc
Repository:
rL LLVM
https:
Prazek added a comment.
Richard?
https://reviews.llvm.org/D21502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart added a comment.
Ping?
I guess i coud just commit it now.
https://reviews.llvm.org/D21502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart added a comment.
Ping
https://reviews.llvm.org/D21502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart added a comment.
ping
https://reviews.llvm.org/D21502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart added a comment.
Regarding this:
struct Foo {
Foo() : some_long_x(0), some_| {}
int some_long_x, some_long_y;
};
That should work fine because the token before the { is the code completion
token, not an identifier. This is basicaly tested by the test with CHECK-CC2.
Howev
ogoffart updated this revision to Diff 69223.
ogoffart added a comment.
Made the requested changes
https://reviews.llvm.org/D21502
Files:
lib/Parse/ParseCXXInlineMethods.cpp
test/CodeCompletion/ctor-initializer.cpp
Index: test/CodeCompletion/ctor-initializer.cpp
===
rsmith added a comment.
Please produce patches with more lines of context in future; phabricator only
lets us comment on lines that are included in the patch, and in this case some
of the relevant parts of the function are not in the context. (The equivalent
of diff -U1000 is a common approach
ogoffart added a comment.
Ping!
https://reviews.llvm.org/D21502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart added a comment.
Ping.
The problem i'm fixing here is how we recover invalid code in the ctor-init
part as we skip the function body.
In particular, we want to know if the '{' is the begining of the body or not.
In C++03, we always consider it as the beginng of the body. The problem
10 matches
Mail list logo
